diff --git a/src/components/deployments/DeploymentJobOutput.js b/src/components/deployments/DeploymentJobOutput.js index ac16b708456ea331995ac65f008d757583a0a718..2bd18871a5caeff2d1c04aba827944c1520b872b 100644 --- a/src/components/deployments/DeploymentJobOutput.js +++ b/src/components/deployments/DeploymentJobOutput.js @@ -41,15 +41,6 @@ export function DeploymentJobOutput({ deploymentJob }) { params }); - const handleError = useCallback( - (error) => { - if (error && !isAbortError(error)) { - showWarning(getErrorMessage(error)); - } - }, - [showWarning] - ); - const getLog = useCallback(() => { if (!deploymentJob.finished || finalResultsNeeded.current) { getLogById(deploymentJob.id); @@ -57,27 +48,28 @@ export function DeploymentJobOutput({ deploymentJob }) { } }, [deploymentJob.finished, deploymentJob.id, getLogById]); - const hasLogError = !!logError; const hasLogData = !!log; const hasAbortError = isAbortError(logError); const showLoading = !hasLogData || !deploymentJob?.started; usePolling( getLog, - logLoading || !logDataReady || hasLogError, + logLoading || !logDataReady || logError, LOG_POLL_INTERVAL, abortGetLogById ); useEffect(() => { - handleError(logError); - }, [logError, handleError]); + if (logError && !hasAbortError) { + showWarning(getErrorMessage(logError)); + } + }, [logError, showWarning]); useEffect(() => { finalResultsNeeded.current = true; }, [deploymentJob.id]); - if (hasLogError && !hasAbortError) { + if (logError && !hasAbortError) { return ( <Stack> <Alert severity="error">{getErrorMessage(logError)}</Alert>