From 43759dd98bc1527943351a206b52e1c6c303b7a3 Mon Sep 17 00:00:00 2001
From: Max Frederiksen <maxfrederiksen@Maxs-MacBook-Air.local>
Date: Wed, 28 Aug 2024 14:21:37 +0200
Subject: [PATCH] refactor comments johanna
---
.../deployments/DeploymentJobOutput.js | 20 ++++++-------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/src/components/deployments/DeploymentJobOutput.js b/src/components/deployments/DeploymentJobOutput.js
index ac16b708..2bd18871 100644
--- a/src/components/deployments/DeploymentJobOutput.js
+++ b/src/components/deployments/DeploymentJobOutput.js
@@ -41,15 +41,6 @@ export function DeploymentJobOutput({ deploymentJob }) {
params
});
- const handleError = useCallback(
- (error) => {
- if (error && !isAbortError(error)) {
- showWarning(getErrorMessage(error));
- }
- },
- [showWarning]
- );
-
const getLog = useCallback(() => {
if (!deploymentJob.finished || finalResultsNeeded.current) {
getLogById(deploymentJob.id);
@@ -57,27 +48,28 @@ export function DeploymentJobOutput({ deploymentJob }) {
}
}, [deploymentJob.finished, deploymentJob.id, getLogById]);
- const hasLogError = !!logError;
const hasLogData = !!log;
const hasAbortError = isAbortError(logError);
const showLoading = !hasLogData || !deploymentJob?.started;
usePolling(
getLog,
- logLoading || !logDataReady || hasLogError,
+ logLoading || !logDataReady || logError,
LOG_POLL_INTERVAL,
abortGetLogById
);
useEffect(() => {
- handleError(logError);
- }, [logError, handleError]);
+ if (logError && !hasAbortError) {
+ showWarning(getErrorMessage(logError));
+ }
+ }, [logError, showWarning]);
useEffect(() => {
finalResultsNeeded.current = true;
}, [deploymentJob.id]);
- if (hasLogError && !hasAbortError) {
+ if (logError && !hasAbortError) {
return (
<Stack>
<Alert severity="error">{getErrorMessage(logError)}</Alert>
--
GitLab