From 92c7a95854f322f863bb1c9150a3cb14b80ec73a Mon Sep 17 00:00:00 2001
From: skybrewer <sky.brewer@ess.eu>
Date: Wed, 3 Jul 2024 17:22:31 +0200
Subject: [PATCH] Fix no-unused-expressions
---
src/components/IOC/ChangeHostAdmin/ChangeHostAdmin.js | 4 +++-
src/components/IOC/IOCDeployDialog/IOCDeployDialog.js | 4 +++-
src/components/IOC/IOCDetailAdmin/IOCDetailAdmin.js | 10 +++++++---
src/components/common/SearchBar/SearchBar.js | 4 +++-
src/components/records/RecordSearch.js | 4 +++-
src/hooks/MountEffects.js | 2 +-
src/views/IOC/IOCListView.js | 4 +++-
src/views/host/HostListView.js | 4 +++-
src/views/records/RecordListView.js | 4 +++-
9 files changed, 29 insertions(+), 11 deletions(-)
diff --git a/src/components/IOC/ChangeHostAdmin/ChangeHostAdmin.js b/src/components/IOC/ChangeHostAdmin/ChangeHostAdmin.js
index 06a840ed..b769a1f3 100644
--- a/src/components/IOC/ChangeHostAdmin/ChangeHostAdmin.js
+++ b/src/components/IOC/ChangeHostAdmin/ChangeHostAdmin.js
@@ -216,7 +216,9 @@ export default function ChangeHostAdmin({
setHost(value);
}}
onInputChange={(event) => {
- event && onHostKeyUp(event.nativeEvent);
+ if (event) {
+ onHostKeyUp(event.nativeEvent);
+ }
}}
autoSelect
filterOptions={(options) => options}
diff --git a/src/components/IOC/IOCDeployDialog/IOCDeployDialog.js b/src/components/IOC/IOCDeployDialog/IOCDeployDialog.js
index 52fe1175..13bf0de6 100644
--- a/src/components/IOC/IOCDeployDialog/IOCDeployDialog.js
+++ b/src/components/IOC/IOCDeployDialog/IOCDeployDialog.js
@@ -197,7 +197,9 @@ export function IOCDeployDialog({
resetError();
}}
onInputChange={(event) => {
- event && onHostKeyUp(event.nativeEvent);
+ if (event) {
+ onHostKeyUp(event.nativeEvent);
+ }
}}
disabled={hasActiveDeployment}
autoSelect
diff --git a/src/components/IOC/IOCDetailAdmin/IOCDetailAdmin.js b/src/components/IOC/IOCDetailAdmin/IOCDetailAdmin.js
index edc4800c..7b89806b 100644
--- a/src/components/IOC/IOCDetailAdmin/IOCDetailAdmin.js
+++ b/src/components/IOC/IOCDetailAdmin/IOCDetailAdmin.js
@@ -192,7 +192,9 @@ export default function IOCDetailAdmin({
setError(null);
}}
onInputChange={(event) => {
- event && onNameKeyUp(event.nativeEvent);
+ if (event) {
+ onNameKeyUp(event.nativeEvent);
+ }
}}
disabled={isDisabled}
autoSelect
@@ -218,12 +220,14 @@ export default function IOCDetailAdmin({
getOptionLabel={(option) => {
return option.url;
}}
- onChange={(_event, value) => {
+ onChange={(event, value) => {
setGitId(value?.id);
setError(null);
}}
onInputChange={(event) => {
- event && onRepoKeyUp(event.nativeEvent);
+ if (event) {
+ onRepoKeyUp(event.nativeEvent);
+ }
}}
renderInput={(params) => (
<TextField
diff --git a/src/components/common/SearchBar/SearchBar.js b/src/components/common/SearchBar/SearchBar.js
index 0167563d..b6657929 100644
--- a/src/components/common/SearchBar/SearchBar.js
+++ b/src/components/common/SearchBar/SearchBar.js
@@ -20,7 +20,9 @@ export function SearchBar({
search(queryString);
}, [search, queryString]);
useEffectAfterMount(() => {
- !showAnimation && !loading && setShowAnimation(true);
+ if (!showAnimation && !loading) {
+ setShowAnimation(true);
+ }
}, [showAnimation, loading, setShowAnimation]);
const solidTime = 1250;
diff --git a/src/components/records/RecordSearch.js b/src/components/records/RecordSearch.js
index b00cd282..eae3766d 100644
--- a/src/components/records/RecordSearch.js
+++ b/src/components/records/RecordSearch.js
@@ -53,7 +53,9 @@ export function RecordSearch({ iocName, rowType }) {
);
useEffect(() => {
- urlState.record_tab && changeTab(deserialize(urlState.record_tab));
+ if (urlState.record_tab) {
+ changeTab(deserialize(urlState.record_tab));
+ }
}, [urlState]);
const changeTab = (tab) => {
diff --git a/src/hooks/MountEffects.js b/src/hooks/MountEffects.js
index bd750c28..98c36bf9 100644
--- a/src/hooks/MountEffects.js
+++ b/src/hooks/MountEffects.js
@@ -10,7 +10,7 @@ function useMountEffect(effect, deps = [], afterMount) {
}
didMountRef.current = true;
return cleanup;
- // eslint-disable-next-line react-hooks/exhaustive-deps
+ // eslint-disable-next-line
}, deps);
}
diff --git a/src/views/IOC/IOCListView.js b/src/views/IOC/IOCListView.js
index ddec0a57..c1d4a819 100644
--- a/src/views/IOC/IOCListView.js
+++ b/src/views/IOC/IOCListView.js
@@ -72,7 +72,9 @@ export function IOCListView() {
};
useEffect(() => {
- urlState.tab && changeTab(deserialize(urlState.tab));
+ if (urlState.tab) {
+ changeTab(deserialize(urlState.tab));
+ }
}, [urlState.tab]);
const urlPagination = useMemo(() => {
diff --git a/src/views/host/HostListView.js b/src/views/host/HostListView.js
index fb6828a5..9b71607b 100644
--- a/src/views/host/HostListView.js
+++ b/src/views/host/HostListView.js
@@ -94,7 +94,9 @@ export function HostListView() {
};
useEffect(() => {
- urlState.tab && changeTab(deserialize(urlState.tab));
+ if (urlState.tab) {
+ changeTab(deserialize(urlState.tab));
+ }
}, [urlState]);
const rowsPerPage = [20, 50];
diff --git a/src/views/records/RecordListView.js b/src/views/records/RecordListView.js
index 9bf98b0c..35e56d61 100644
--- a/src/views/records/RecordListView.js
+++ b/src/views/records/RecordListView.js
@@ -78,7 +78,9 @@ export function RecordListView() {
};
useEffect(() => {
- urlState.tab && changeTab(deserialize(urlState.tab));
+ if (urlState.tab) {
+ changeTab(deserialize(urlState.tab));
+ }
}, [urlState]);
const urlPagination = useMemo(() => {
--
GitLab