From ac8d934796d28663f96701236c10cc8e31139572 Mon Sep 17 00:00:00 2001
From: Johanna Szepanski <johanna.szepanski@softhouse.se>
Date: Wed, 6 Nov 2024 13:13:18 +0100
Subject: [PATCH] fixed exhaustive-deps warnings

---
 src/components/IOC/IOCDelete/IOCDelete.js              | 9 ++++++++-
 src/components/IOC/IOCDeployDialog/IOCDeployDialog.tsx | 2 +-
 src/components/IOC/IOCService/IOCService.js            | 8 +++++---
 src/components/IOC/IOCStatus/IOCStatus.js              | 2 +-
 src/components/common/LogStream/LogStreamConsole.tsx   | 2 +-
 src/components/common/Status/Status.js                 | 2 +-
 src/components/host/HostStatus/HostStatus.js           | 2 +-
 7 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/src/components/IOC/IOCDelete/IOCDelete.js b/src/components/IOC/IOCDelete/IOCDelete.js
index f88a0267..3aa06ac2 100644
--- a/src/components/IOC/IOCDelete/IOCDelete.js
+++ b/src/components/IOC/IOCDelete/IOCDelete.js
@@ -46,7 +46,14 @@ export default function IOCDelete({ ioc, buttonDisabled, setButtonDisabled }) {
       showSnackBar(`IOC ${ioc.namingName} deleted`, "success");
       navigate("/iocs");
     }
-  }, [dataready, navigate, error, setButtonDisabled]);
+  }, [
+    dataready,
+    navigate,
+    error,
+    setButtonDisabled,
+    ioc.namingName,
+    showSnackBar
+  ]);
 
   let disabledButtonTitle = "";
 
diff --git a/src/components/IOC/IOCDeployDialog/IOCDeployDialog.tsx b/src/components/IOC/IOCDeployDialog/IOCDeployDialog.tsx
index 6c8f6dc6..ef55d312 100644
--- a/src/components/IOC/IOCDeployDialog/IOCDeployDialog.tsx
+++ b/src/components/IOC/IOCDeployDialog/IOCDeployDialog.tsx
@@ -109,7 +109,7 @@ export function IOCDeployDialog({
     if (!hasHostData && query && query.length > 2) {
       getHosts({ text: `${query}` });
     }
-  }, [query, getHosts]);
+  }, [query, getHosts, hasHostData]);
 
   useEffect(() => {
     getTagOrCommitIds(gitProjectId, "", "CONTAINS");
diff --git a/src/components/IOC/IOCService/IOCService.js b/src/components/IOC/IOCService/IOCService.js
index 116d6273..776bf77a 100644
--- a/src/components/IOC/IOCService/IOCService.js
+++ b/src/components/IOC/IOCService/IOCService.js
@@ -36,7 +36,7 @@ export function IOCService({
       setError(jobError);
       setButtonDisabled(false);
     }
-  }, [jobError]);
+  }, [jobError, setButtonDisabled]);
 
   useEffect(() => {
     if (jobData && (!command || command.id !== jobData.id)) {
@@ -74,7 +74,8 @@ export function IOCService({
     jobLazyParams,
     resetUI,
     setButtonDisabled,
-    startJob
+    startJob,
+    ioc.id
   ]);
 
   const stop = useCallback(() => {
@@ -99,7 +100,8 @@ export function IOCService({
     jobLazyParams,
     resetUI,
     setButtonDisabled,
-    startJob
+    startJob,
+    ioc.id
   ]);
 
   const onStartModalClose = useCallback(() => {
diff --git a/src/components/IOC/IOCStatus/IOCStatus.js b/src/components/IOC/IOCStatus/IOCStatus.js
index 38a19c0b..85190001 100644
--- a/src/components/IOC/IOCStatus/IOCStatus.js
+++ b/src/components/IOC/IOCStatus/IOCStatus.js
@@ -39,7 +39,7 @@ export const IOCStatus = ({ id, hideAlerts }) => {
     return () => {
       abortCallFetchIocAlerts();
     };
-  }, [iocStateStatus, hideAlerts]);
+  }, [hideAlerts, abortCallFetchIocAlerts, callFetchIocAlerts]);
 
   return (
     <Grid
diff --git a/src/components/common/LogStream/LogStreamConsole.tsx b/src/components/common/LogStream/LogStreamConsole.tsx
index 8e5a0522..ec2cf2cd 100644
--- a/src/components/common/LogStream/LogStreamConsole.tsx
+++ b/src/components/common/LogStream/LogStreamConsole.tsx
@@ -66,7 +66,7 @@ export const LogStreamConsole = ({
         });
       }
     }
-  }, [dataReady]);
+  }, [dataReady, autoScrollEnabled, handleScroll, log]);
 
   return (
     <>
diff --git a/src/components/common/Status/Status.js b/src/components/common/Status/Status.js
index 9fcdc785..53a0b20b 100644
--- a/src/components/common/Status/Status.js
+++ b/src/components/common/Status/Status.js
@@ -24,7 +24,7 @@ export function Status({ state, alert, hideAlerts = false, getStatusFcn }) {
     if (state) {
       setStatus(getStatusFcn(state, alert));
     }
-  }, [state, alert]);
+  }, [state, alert, getStatusFcn]);
 
   return (
     <>
diff --git a/src/components/host/HostStatus/HostStatus.js b/src/components/host/HostStatus/HostStatus.js
index f4f88185..69f2fae3 100644
--- a/src/components/host/HostStatus/HostStatus.js
+++ b/src/components/host/HostStatus/HostStatus.js
@@ -37,7 +37,7 @@ export const HostStatus = ({ hostId, hideAlerts }) => {
     return () => {
       abortCallFetchHostAlerts();
     };
-  }, [hostStateStatus, hideAlerts]);
+  }, [hideAlerts, callFetchHostAlerts, abortCallFetchHostAlerts]);
 
   return (
     <Status
-- 
GitLab