Command line option `-t`/`--broker_topic` ignored
The common EFU command line argument parser includes an optional argument -t
/--broker_topic
to set the topic used for EFU events.
https://github.com/ess-dmsc/event-formation-unit/blob/113c51a7fff7d34bf47dd76b17a489fdaf43be60/src/common/detector/EFUArgs.cpp#L38
This command line options is not used, however, since it gets overwritten after the parser is called https://github.com/ess-dmsc/event-formation-unit/blob/113c51a7fff7d34bf47dd76b17a489fdaf43be60/src/efu/MainProg.cpp#L26
The overwriting behavior was added as part of #635.
It looks like all EFU variants check for an empty DetectorSettings.KafkaTopic
and provide the equivalent default
Therefore it may be safe to remove line 26 of src/efu/MainProg.cpp
Alternatively, line 26 could be protected by a empty-string check and the per-module equivalent checks could be dropped, e.g.,
if (DetectorSettings.KafkaTopic.empty()){
DetectorSettings.KafkaTopic = instrument + "_detector";
}