diff --git a/TODO b/TODO index 0c739db9289159931f4b175c018bf483f1253696..3aa6c4b2678588441820d44a82ee8b2d1d6e4c8d 100644 --- a/TODO +++ b/TODO @@ -26,7 +26,6 @@ Version 1.5.0: * Bus simulator interface. * Implement ecrt_master_slave() in kernel space. * Rename phy-commands to register commands. -* Timeout for sync manager config after clearing. Future issues: diff --git a/master/fsm_slave_config.c b/master/fsm_slave_config.c index b0bcb034c450d3df26dc3ee573a0174fc4cfefeb..57c0f6d86f8b57303def847cf584bbd629173156 100644 --- a/master/fsm_slave_config.c +++ b/master/fsm_slave_config.c @@ -451,6 +451,8 @@ void ec_fsm_slave_config_enter_mbox_sync( slave->sii.boot_tx_mailbox_size; } + fsm->take_time = 1; + fsm->retries = EC_FSM_RETRIES; fsm->state = ec_fsm_slave_config_state_mbox_sync; } @@ -479,7 +481,36 @@ void ec_fsm_slave_config_state_mbox_sync( return; } - if (datagram->working_counter != 1) { + if (fsm->take_time) { + fsm->take_time = 0; + fsm->jiffies_start = datagram->jiffies_sent; + } + + /* Because the sync manager configurations are cleared during the last + * cycle, some slaves do not immediately respond to the mailbox sync + * manager configuration datagram. Therefore, resend the datagram for + * a certain time, if the slave does not respond. + */ + if (datagram->working_counter == 0) { + unsigned long diff = datagram->jiffies_received - fsm->jiffies_start; + + if (diff >= HZ) { + slave->error_flag = 1; + fsm->state = ec_fsm_slave_config_state_error; + EC_ERR("Timeout while configuring mailbox sync managers of" + " slave %u.\n", slave->ring_position); + return; + } + else if (slave->master->debug_level) { + EC_DBG("Resending after %u ms...\n", + (unsigned int) diff * 1000 / HZ); + } + + // send configuration datagram again + fsm->retries = EC_FSM_RETRIES; + return; + } + else if (datagram->working_counter != 1) { slave->error_flag = 1; fsm->state = ec_fsm_slave_config_state_error; EC_ERR("Failed to set sync managers of slave %u: ", diff --git a/master/fsm_slave_config.h b/master/fsm_slave_config.h index a6e5680954975ee7b11a72cea8f6dc7c323b189c..0af962c191c276020770e2245fdf38c53623cbde 100644 --- a/master/fsm_slave_config.h +++ b/master/fsm_slave_config.h @@ -60,6 +60,8 @@ struct ec_fsm_slave_config unsigned int retries; /**< Retries on datagram timeout. */ ec_sdo_request_t *request; /**< SDO request for SDO configuration. */ ec_sdo_request_t request_copy; /**< Copied SDO request. */ + unsigned long jiffies_start; /**< For timeout calculations. */ + unsigned int take_time; /**< Store jiffies after datagram reception. */ }; /*****************************************************************************/