From 1d0b3d6af97bb5908f3c841a3b9b8c0d47eb5767 Mon Sep 17 00:00:00 2001
From: Lars Johansson <lars.johansson@ess.eu>
Date: Fri, 14 Jun 2024 13:14:07 +0200
Subject: [PATCH] Fix Sonar issues
Avoid field dependency injection.
---
.../rest/controller/VerificationController.java | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/main/java/org/openepics/names/rest/controller/VerificationController.java b/src/main/java/org/openepics/names/rest/controller/VerificationController.java
index 9e811616..f17bd256 100644
--- a/src/main/java/org/openepics/names/rest/controller/VerificationController.java
+++ b/src/main/java/org/openepics/names/rest/controller/VerificationController.java
@@ -183,17 +183,17 @@ public class VerificationController {
private static final SimpleDateFormat SDF = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS");
+ private final IDeviceRevisionRepository deviceRevisionRepository;
+ private final INamePartRevisionRepository namePartRevisionRepository;
+
private final HolderIWipRepositories holderIWipRepositories;
private final HolderIRepositories holderIRepositories;
private final HolderRepositories holderRepositories;
- @Autowired
- IDeviceRevisionRepository deviceRevisionRepository;
- @Autowired
- INamePartRevisionRepository namePartRevisionRepository;
-
@Autowired
public VerificationController(
+ IDeviceRevisionRepository deviceRevisionRepository,
+ INamePartRevisionRepository namePartRevisionRepository,
IWipNameRepository iWipNameRepository,
IWipSystemGroupRepository iWipSystemGroupRepository,
IWipSystemRepository iWipSystemRepository,
@@ -220,7 +220,10 @@ public class VerificationController {
AuditNameRepository auditNameRepository,
AuditStructureRepository auditStructureRepository) {
- holderIWipRepositories = new HolderIWipRepositories(
+ this.deviceRevisionRepository = deviceRevisionRepository;
+ this.namePartRevisionRepository = namePartRevisionRepository;
+
+ this.holderIWipRepositories = new HolderIWipRepositories(
iWipNameRepository,
iWipSystemGroupRepository,
iWipSystemRepository,
--
GitLab