Skip to content
Snippets Groups Projects
  1. Aug 07, 2019
  2. Jul 10, 2019
    • Benjamin Bertrand's avatar
      Version 0.24.1 · 52c9baca
      Benjamin Bertrand authored
      0.24.1
      52c9baca
    • Benjamin Bertrand's avatar
      Fix sorting of items with some null stack_member · ab9b49b8
      Benjamin Bertrand authored
       '<' not supported between instances of 'NoneType' and 'int'
      
      Sorting worked if all stack_members were None, but not if some were null
      and some int.
      Fixed by converting None to Infinity (so None values are at the end of
      the list.
      
      JIRA INFRA-1112 #action In Progress
      ab9b49b8
    • Benjamin Bertrand's avatar
      Version 0.24.0 · c1ff2e22
      Benjamin Bertrand authored
      0.24.0
      c1ff2e22
    • Benjamin Bertrand's avatar
      Add extra items info to hosts json model · 0318858e
      Benjamin Bertrand authored
      Linked items are by default returned as a list of ICS id.
      When recursive is True, a list of {ics_id, serial_number, stack_member}
      is returned instead.
      
      Items are always returned sorted by stack_member or ics_id when
      stack_member is null.
      
      Allow to add the serial_number and stack_member to the Ansible variables
      in csentry dynamic inventory. Useful for switches.
      
      JIRA INFRA-1111 #action In Progress
      0318858e
  3. Jun 14, 2019
  4. Jun 13, 2019
  5. Jun 04, 2019
  6. May 13, 2019
    • Benjamin Bertrand's avatar
      Version 0.21.1 · ec51b3e8
      Benjamin Bertrand authored
      0.21.1
      ec51b3e8
    • Benjamin Bertrand's avatar
      Remove caching of user retrieval · be364ef4
      Benjamin Bertrand authored
      The caching of the load_user function already created several bugs
      (INFRA 908/1018).
      It requires to think about adding (or deleting in the admin view)
      the current_user to the session. This is easy to miss.
      
      It saves some database queries but we don't need this optimization.
      Performances are not impacted and are good enough so far.
      
      Removing the caching makes the application more robust and easier to
      maintain.
      
      JIRA INFRA-1025 #action In Progress
      be364ef4
    • Benjamin Bertrand's avatar
      Fix users synchronization · d2bb6124
      Benjamin Bertrand authored
      The LDAP_USER_DN was changed in 0.21.0.
      This resulted in more entries returned when searching for users
      and all users being disabled...
      
      We were only looking into "OU=ESS Users" before.
      Inactive users are put under "OU=InActiveUsers" in AD.
      
      JIRA INFRA-1026 #action In Progress
      d2bb6124
  7. May 10, 2019
  8. May 09, 2019
    • Benjamin Bertrand's avatar
      Fix IOC indexation · 2b588173
      Benjamin Bertrand authored
      Regression from b9c1b838
      
      Calling utils.trigger_ioc_repository_creation runs launch_task
      which does a db.session.add(task). This raises:
      
      SAWarning: Usage of the 'Session.add()' operation is not currently
      supported within the execution stage of the flush process. Results may
      not be consistent.  Consider using alternative event listeners or
      connection-level operations instead.
      
      SAWarning: Attribute history events accumulated on 1 previously clean
      instances within inner-flush event handlers have been reset, and will
      not result in database updates.
      
      The result is that the host is not added to the elasticsearch index.
      
      We can't trigger the task in after_update/after_insert events.
      Perform the call in the view instead. It's temporary anyway. This should
      be handled by IOC Factory.
      
      JIRA INFRA-1015
      2b588173
    • Benjamin Bertrand's avatar
      Improve documentation · e265aec4
      Benjamin Bertrand authored
      e265aec4
  9. May 08, 2019
  10. Apr 25, 2019
  11. Apr 24, 2019
    • Benjamin Bertrand's avatar
      Fix exception when no network selected · 9e500391
      Benjamin Bertrand authored
      1. It's possible to erase the network when creating a host.
      The exception raised was due to the ip_in_range validator
      where a select using the network_id is performed.
      This is now catched to raise a ValidationError.
      2. Add some javascript to remove the is-invalid class on the network and
      IP fields when changing them
      
      JIRA INFRA-810 #action In Progress
      9e500391
  12. Apr 23, 2019
  13. Apr 05, 2019
  14. Apr 03, 2019
  15. Apr 02, 2019
  16. Mar 27, 2019
    • Benjamin Bertrand's avatar
      Version 0.19.2 · bf14cc97
      Benjamin Bertrand authored
      0.19.2
      bf14cc97
    • Benjamin Bertrand's avatar
      Add depends_on field on Task · ebae1b17
      Benjamin Bertrand authored
      Allow to trigger a new core service update only if there is none
      depending on the triggered inventory update.
      
      JIRA INFRA-895
      ebae1b17
    • Benjamin Bertrand's avatar
      Increase timeout for core services update · 27b44173
      Benjamin Bertrand authored
      As the core service update doesn't depend anymore on each other but only
      on the inventory update, 2 can be launched almost at the same time.
      As they can't run in parallel, the second one will only start when the
      first one is done, meaning that it can take more than 180 seconds to
      complete.
      
      Increasing the timeout to 500 seconds should avoid the task to be
      reported as failed when it just took longer to run.
      
      JIRA INFRA-895 #action In Progress
      27b44173
    • Benjamin Bertrand's avatar
      Fix model update in admin interface · 88f54ded
      Benjamin Bertrand authored
      Following exception is raised when trying to update a network from
      flask-admin:
      sqlalchemy.exc.InvalidRequestError: Can't attach instance <User at 0x7f6f0e39ce10>;
      another instance with key (<class 'app.models.User'>, (1,), None) is already present in this session.
      
      1. If we remove the caching of the load_user method, the problem
      disappears.
      2. When updating a Network, this trigger an inventory update in
      before_flush which adds a task to the session. This is when the
      current_user is added to the session and the error raised.
      
      So the problem is linked to the user caching and flask-admin.
      
      The workaround is to remove the user object added by flask-admin to the
      session.
      
      JIRA INFRA-908 #action In Progress
      88f54ded
Loading