Skip to content
Snippets Groups Projects
  1. May 11, 2023
  2. May 10, 2023
    • Lucas Magalhães's avatar
      Fix memory leak in parse_semver · fb57df48
      Lucas Magalhães authored
      fb57df48
    • Lucas Magalhães's avatar
      Fix possible memory leak in runScript.c · 640e5721
      Lucas Magalhães authored
      This was reported by cppcheck over require's code:
      require-ess/src/runScript.c:128:12: error: Common realloc mistake: 'line_raw' nulled but not freed upon failure [memleakOnRealloc]
            if ((line_raw = realloc(line_raw, line_raw_size *= 2)) == NULL)
                 ^
      
      Unfortunately realloc can return null, in that case if we use something
      like
      line_raw = realloc(line_raw, size);
      The memory pointed by line_raw is lost.
      640e5721
    • Lucas Magalhães's avatar
      Fix uninitialized values in require.c · b2085515
      Lucas Magalhães authored
      This was reported running cppcheck over require's code.
      require-ess/src/require.c:1002:33: error: Uninitialized variable: &modulediroffs [uninitvar]
                     dirname, module, &modulediroffs);
                                      ^
      require-ess/src/require.c:996:18: note: Assuming condition is false
            if (dirlen == 0) continue; /* ignore empty driverpath elements */
                       ^
      require-ess/src/require.c:1002:33: note: Uninitialized variable: &modulediroffs
                     dirname, module, &modulediroffs);
                                      ^
      b2085515
    • Lucas Magalhães's avatar
      Fix format overflow errors from GCC13 in require.c · 875791dc
      Lucas Magalhães authored
      In function ‘compareVersions’,
          inlined from ‘require_priv’ at .././src/require.c:1025:29:
      .././src/require.c:640:9: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
        640 |   debug("require: compareVersions(found=%s, request=%s)\n", found, request);
            |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      .././src/require.c:601:28: note: in definition of macro ‘debug’
        601 |   if (requireDebug) printf(__VA_ARGS__)
            |                            ^~~~~~~~~~~
      .././src/require.c: In function ‘require_priv’:
      .././src/require.c:640:53: note: format string is defined here
        640 |   debug("require: compareVersions(found=%s, request=%s)\n", found, request);
            |                                                     ^~
      In function ‘compareVersions’,
          inlined from ‘require_priv’ at .././src/require.c:1025:29:
      .././src/require.c:640:9: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
        640 |   debug("require: compareVersions(found=%s, request=%s)\n", found, request);
            |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      .././src/require.c:601:28: note: in definition of macro ‘debug’
        601 |   if (requireDebug) printf(__VA_ARGS__)
            |                            ^~~~~~~~~~~
      .././src/require.c: In function ‘require_priv’:
      .././src/require.c:640:53: note: format string is defined here
        640 |   debug("require: compareVersions(found=%s, request=%s)\n", found, request);
            |                                                     ^~
      .././src/require.c:1031:50: warning: ‘%s’ directive argument is null [-Wformat-overflow=]
       1031 |                 printf("require: %s %s may match %s\n", module, currentFilename,
            |                                                  ^~
      875791dc
    • Lucas Magalhães's avatar
      Fix memory leak in require_priv · fd05d245
      Lucas Magalhães authored
      fd05d245
  3. May 08, 2023
  4. May 04, 2023
  5. Apr 11, 2023
  6. Apr 06, 2023
  7. Apr 05, 2023
  8. Apr 04, 2023
  9. Mar 16, 2023
    • Simon Rose's avatar
      Partial reversion of af57525d · 040a4d5d
      Simon Rose authored
      The issue is that `COMMANDLINE_LIBRARY` is used by EPICS base to link against
      some other libraries; removing this line means that every lib*.so now links
      against libreadline.so. This isn't _strictly speaking_ an issue because
      `softIocPVA` also ultimately depends on libreadline. However, it is bad
      practice.
      040a4d5d
  10. Feb 14, 2023
  11. Feb 13, 2023
  12. Feb 08, 2023
  13. Feb 07, 2023
  14. Jan 31, 2023
  15. Jan 30, 2023
  16. Jan 27, 2023
  17. Jan 26, 2023
  18. Jan 25, 2023
  19. Jan 23, 2023
  20. Jan 20, 2023
    • Lucas Magalhães's avatar
      Move module_VERSION definitions to first make call (fix E3-1112) · 556a5d39
      Lucas Magalhães authored
      From e3-require 4.0.0 to 5.0.0 we changed FETCH_BUILD_NUMBER to
      FETCH_REVISION_NUMBER. But the following error happens if you try to
      build e3-adandor, for example:
      
      2023-01-19 13:41:49,129 [  DEBUG  ] e3.utils: stderr: HEAD is now at 6f3a1f4... Merge pull request #44 from sudilav/master
      msi: Can't open file 'ADBase.template'
      input: 'include "ADBase.template"
      ' at line 5 of  file andorApp/Db/andorCCD.template
      
      The root cause is a mixture of two things, a change we made for 5.0.0
      and an old behavior:
      1. We changed when the db expansions happen in
      b226a847c403eba79bc91efee18d225ed2753c7
      2. The variables holding the dependency versions are defined on the
      second make call after defining T_A.
      
      This commit fixes the issue by moving the module_VERISON definitions
      to the first make call. Whit this we restrict the usage of
      FETCH_REVISION_NUMBER to the modules defined as a dependency in
      configure/CONFIG_MODULE.
      556a5d39
  21. Dec 16, 2022
Loading