CE-1847: use common GlobalAppBar

• Replaces custom GlobalAppBar with nav menu using the common-ui component
• Replaces the user login/logout buttons (uses common context and components, and retains the redirect to /login when accessing unauthorized resources)
• does NOT add the "create ioc button" to the global app bar (tbd in CE-426)
• removes unused getUser method from user context
• ensures page and app title is set, adds a breadcrumb utility function

Closes CE-1847

requested review from @alexandermadsen, @imretoth, @domonkosgulyas, and @simonrose

assigned to @christinajenks

added 1 commit

• 12470d31 - CE-1847: remove commented out code

Compare with previous version

changed the description

I did already spot an issue: the title seems to be overridden sometimes. I'll work on that...any other feedback much appreciated!

Edit: That issue should now be fixed, pending you seeing it when I eventually redeploy.

added 1 commit

• 7ac96ab4 - CE-1847: fix intermittent useEffect error, overridden title

Compare with previous version

mentioned in merge request !316 (merged)

I'm not sure if it's from this change, but we are once again getting the weird button colour issue:

Otherwise, the behaviour and visual review looks good to me.

resolved all threads

Just nitpicking: the title looks cropped a bit from the bottom in the appBar:

Otherwise code looks good, and UI behaves as expected!

This would actually be a problem with the common component Could you raise a followup issue for this?

closed

approved this merge request

reopened

merged

mentioned in commit 52f9e85c