CE-2036: Fix record table search functionality

Modified the request parameter in the record (search) page.

The BE is also modified the filtering method to use contains instead of the current equals method.

Solution is deployed to the TEST environment - if anyone would like to test it.

requested review from @alexandermadsen, @anderslindh1, @christinajenks, @domonkosgulyas, and @simonrose

assigned to @imretoth

Not sure if part of the issue or not...The record_name is definitely sent, but not the filter param...or, more accurately I guess, it would be probably sent if it was ever set?

Yeah, that was the root cause of the problem, because the Record endpoint(s) don't have parameter called filter, so that can't be sent to the BE:

Right! I remember seeing that too, and I didn't connect the dots this morning

In that case, I think it needs to be updating the pv_status instead of filter param. May be a separate issue that param isn't actually being set or changed when changing the "Only Active", "Only Inactive" etc tabs.

Glancing at it, I'm pretty sure it's the handleTabChange method...It should be comparing correctly since tab is a primitive value...but maybe the tab api has changed with the MUI upgrade?

Huh...I'm also not sure how we're supposed to be sending ioc_name either. It works in the BE but I am actually not sure how/where we're supposed to send it from the FE? Is this one of those "hidden" params that isn't documented and needs to be entered in the URL instead of UI?

Oh NVM we use it in IOCLiveStatus, on the IOC Details page

For some reason though, https://ce-deploy-test.cslab.esss.lu.se/api/v1/iocs?deployment_status=ALL&page=0&limit=20 returns an HTTP 500 though. Same for specific IOCs that do exist in prod and should exist in test (like https://ce-deploy-test.cslab.esss.lu.se/api/v1/iocs/1302). Doesn't seeem to be related to this request, could be some other issue?

Can't verify that page for that reason, but glancing at the code (ultimately the RecordSearch component) it might be okay

Yeah, the pv_status is a good catch, I missed to check/modify that one! As for the IOCs... well, we renamed the owner field in the ioc_version DB table to created_by, and the daily DB dump overwrote the whole DB table so now all the IOC related fetches fail - until we re-deploy the BE which converts the field again.

Modification is re-deployed to the TEST environment (searching for IOCs works fine till the next DB dumps kicks in).

Functional review OK - seems to work as expected

Also confirming this works as expected now!

Thank you for the review!

added 1 commit

• 8175dc43 - Fix Record status filter

Compare with previous version

resolved all threads

approved this merge request

mentioned in commit 7a741bb5

merged