CE-1994: Replace home button with ESS logo

Ticket: CE-1994

Replace home button with ESS logo

requested review from @christinajenks, @domonkosgulyas, and @imretoth

assigned to @alexandermadsen

changed title from Replace home button with ESS logo to CE-1994: Replace home button with ESS logo

This is more of an aesthetic bit...ish...but also kinda icky design with those thin lines in the logo. Could 36px size look better? @anderslindh1

Current (24px):

Proposed (36px):

Too Big for your reference (48px):

Spacing in both seems to satisfy the proportions stated in the style guide.

So, yeah @christinajenks et all. This looks a bit, not so good, but I kinda followed what was there with just replacing the Home button.

So , you agree with Tina (and me for that matter) that this link/button can be in a different size that all the other button, since it's actually not just a home button, the logo for the site...

If the proportions are satisfied (including the required padding), feel free to make the change. My only concern is that this might make the top menu very tall, which isn't very aesthetically pleasing.

Actually, I don't think we should modify the sizing. Both Confluence and JIRA uses small logos.

Ohhhh, nvm, I just saw that the last picture by Tina actually wasn't her recommendation. Yeah 36px looks good Sorry for the confusion

But the 48px is an optical illusion, the whole image is zoomed in as well, so it's not a fair comparison

OK. This does not affect my opinion. A larger vector image with curved lines will of course look better the larger it is. My preference for an upper cap is based on a) that we should try to meet the proportions and margins/padding listed in the design manual, and b) that we should not make the top navigational bar too large/tall, because it occupies too much screen space and does not look aesthetically pleasing to me. I agree with your suggestion to diverge from the standard icon size to reduce pixelation.

From the proposals given so far (the screenshots), 36px seems better than 48px, considering all of the above.

Ok, so 36x36px it is

added 1 commit

• b4fe815d - Larger logo

Compare with previous version

Shouldn't most of this be done in the common UI library btw?

Should, maybe, but it's not built that way. Thought I can investigate if it would be possible, and if that solution then would be desirable.

That's OK - no need - we can look at that as a potential refactoring later on once we update CE template. We already have a separate ticket for that.

approved this merge request

Code

Visual (uses 36px as approved by agreed)

mentioned in commit 22f8e39b

merged