Skip to content
Snippets Groups Projects

CE-3050: host log stream + IOC log stream in SimpleAccordion

Merged CE-3050: host log stream + IOC log stream in SimpleAccordion
All threads resolved!
Merged Max Frederiksen requested to merge CE-3050 into develop
All threads resolved!

follow up:

  • add fake data for log stream in story IOCDetailsView and HostDetailsView

    After digging further into this it seems like what is blocking the mocked procServLogLines from rendering in Storybook is that we have a mocked auth check to see if the user has correct permissions. This seems reasonable, however, it's a bit inconsistent since other endpoints which also should require it, eg. hostSysLogLines does not. After my discussion with @johannaszepanski we decided that the simplest way forward for now is to simply remove the need for auth for that endpoint.

  • Investigate why mockServiceWorker.js gets auto-formatted when running storybook

    Couldn't reproduce the issue, so skipping this for now. If I see it pop up again I'll look deeper into it and create a ticket.

Edited by Max Frederiksen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Max Frederiksen changed the description

    changed the description

  • Max Frederiksen resolved all threads

    resolved all threads

  • Max Frederiksen changed the description

    changed the description

  • Max Frederiksen added 3 commits

    added 3 commits

    • abf9f69c - Remove <Stack/> from HostDetailsView.js
    • 12a34940 - Replace <LokiContainer/> w <LokiPanel/> + add hostName check
    • 742e3179 - Refactor LokiResponse.json name and data + remove auth for fetchProcServLogLines

    Compare with previous version

  • Max Frederiksen marked this merge request as ready

    marked this merge request as ready

  • Code :thumbsup:

    Visual :thumbsup:

    well done!

  • Johanna Szepanski approved this merge request

    approved this merge request

  • Max Frederiksen added 6 commits

    added 6 commits

    • 742e3179...da62543f - 2 commits from branch develop
    • 086e5476 - Put host log stream + IOC log stream in SimpleAccordion
    • da389c9f - Remove <Stack/> from HostDetailsView.js
    • 6cea7763 - Replace <LokiContainer/> w <LokiPanel/> + add hostName check
    • be2b4d42 - Refactor LokiResponse.json name and data + remove auth for fetchProcServLogLines

    Compare with previous version

  • mentioned in commit 3a8d1aba

  • Please register or sign in to reply
    Loading