CE-3050: host log stream + IOC log stream in SimpleAccordion
follow up:
-
add fake data for log stream in story IOCDetailsView and HostDetailsViewAfter digging further into this it seems like what is blocking the mocked procServLogLines from rendering in Storybook is that we have a mocked auth check to see if the user has correct permissions. This seems reasonable, however, it's a bit inconsistent since other endpoints which also should require it, eg. hostSysLogLines does not. After my discussion with @johannaszepanski we decided that the simplest way forward for now is to simply remove the need for auth for that endpoint.
-
Investigate why mockServiceWorker.js gets auto-formatted when running storybookCouldn't reproduce the issue, so skipping this for now. If I see it pop up again I'll look deeper into it and create a ticket.
Merge request reports
Activity
assigned to @maxfrederiksen
requested review from @johannaszepanski, @skybrewer, and @domonkosgulyas
- Resolved by Max Frederiksen
Noticed there are some failing tests. Probably should have ran those locally before committing, will review them tomorrow, marking it as draft for now.
Both suggested follow-ups seem fair, so please just go ahead and create tasks for those in the backlog - Sky, Simon, or myself can go through what level of detail we usually add. Feel free to just add technical items you think we ought to do to the backlog whenever. Your first suggestion here (mock the log streams) would be fine to also as part of this MR if not all too complicated to do.
There should also be a job log stream, but perhaps that is already in an accordion.
Nitpick, but if you also put a short summary in the MR title it's easier to see what it concerns from the project and group views on GL:
Edited by Anders Lindh Olsson- Resolved by Max Frederiksen
- Resolved by Max Frederiksen
added 6 commits
-
742e3179...da62543f - 2 commits from branch
develop
- 086e5476 - Put host log stream + IOC log stream in SimpleAccordion
- da389c9f - Remove <Stack/> from HostDetailsView.js
- 6cea7763 - Replace <LokiContainer/> w <LokiPanel/> + add hostName check
- be2b4d42 - Refactor LokiResponse.json name and data + remove auth for fetchProcServLogLines
Toggle commit list-
742e3179...da62543f - 2 commits from branch
mentioned in commit 3a8d1aba