CE-3061: Update ioc alerts and status separately

Deployed to both DEMO and TEST. You can also check all scenarios running storybook for IOC List view and IOC Details view if running it locally

This is where the changes occur:

IOC List view, status column, where status (active/inactive) and alerts (badge with error or warning symbol) is fetched in separate calls.

IOC details view, alerts are displayed as banners and status is displayed only as active/inactive/disabled without alert badge

Possible UI states:

active

inactive

disabled

active with severity error

active with severity warning

inactive with severity error

inactive with severity warning

disabled with severity error

disabled with severity warning

Status response:

deployed:
{
  "iocId": 21,
  "alertSeverity": null,
  "alerts": [],
  "active": true
}started:
{
  "iocId": 21,
  "alertSeverity": null,
  "alerts": [],
  "active": true
}stopped:
{
  "iocId": 21,
  "alertSeverity": null,
  "alerts": [],
  "active": null
}undeployed:
{
  "iocId": 21,
  "alertSeverity": "INFO",
  "alerts": [
    {
      "type": "INFO",
      "message": "IOC is not deployed",
      "link": null
    }
  ],
  "active": false
}

assigned to @johannaszepanski

added 6 commits

• 15b23666 - Use new endpoint to fetch ioc alerts separate
• 0153d34f - generalised ioc icon components and data and moved files to common/status
• ba4505cf - updated import path for CommandTypeIcon
• c898c05a - conditionally fetch alerts based on hideAlerts props
• 183cdd44 - use the IocStatus that fetches status and alerts separately in Ioc details view
• f412cf1f - move loader from IOC status to Status component to avoid getting a flickering unknown state

Compare with previous version

marked this merge request as ready

requested review from @domonkosgulyas, @maxfrederiksen, and @skybrewer

marked this merge request as draft

removed review request for @skybrewer, @domonkosgulyas, and @maxfrederiksen

added 12 commits

• f412cf1f...3a8d1aba - 5 commits from branch develop
• e6155586 - Use new endpoint to fetch ioc alerts separate
• f2802695 - generalised ioc icon components and data and moved files to common/status
• 3a87e4a6 - updated import path for CommandTypeIcon
• 00a4e4f4 - conditionally fetch alerts based on hideAlerts props
• 8a0ce780 - use the IocStatus that fetches status and alerts separately in Ioc details view
• 8c414ca3 - move loader from IOC status to Status component to avoid getting a flickering unknown state
• 07890b0d - adjusted IOC details story and mockdata to accomodate api changes

Compare with previous version

changed the description

added 2 commits

• 0b660407 - adjusted IOC details story and mockdata to accomodate api changes
• 31407e53 - updated status logic and story to accommodate BE fix for stopped IOCs

Compare with previous version

added 15 commits

• 31407e53...eeadb1e7 - 7 commits from branch develop
• c69eba61 - Use new endpoint to fetch ioc alerts separate
• de8aa811 - generalised ioc icon components and data and moved files to common/status
• 2c696ce9 - updated import path for CommandTypeIcon
• 767b561d - conditionally fetch alerts based on hideAlerts props
• bab1a5d6 - use the IocStatus that fetches status and alerts separately in Ioc details view
• b60b16e7 - move loader from IOC status to Status component to avoid getting a flickering unknown state
• b2b9aebc - adjusted IOC details story and mockdata to accomodate api changes
• c2ff5134 - updated status logic and story to accommodate BE fix for stopped IOCs

Compare with previous version

added 1 commit

• c6c7ff59 - added new statuses disabledAlert and disabledWarning

Compare with previous version

added 9 commits

• 0165e2ca - Use new endpoint to fetch ioc alerts separate
• b7bb8380 - generalised ioc icon components and data and moved files to common/status
• e1c45401 - updated import path for CommandTypeIcon
• 6f47b5fd - conditionally fetch alerts based on hideAlerts props
• 0c83635c - use the IocStatus that fetches status and alerts separately in Ioc details view
• e493ca0d - move loader from IOC status to Status component to avoid getting a flickering unknown state
• 94f42b0a - adjusted IOC details story and mockdata to accomodate api changes
• b2927bf3 - updated status logic and story to accommodate BE fix for stopped IOCs
• ad7f8ba3 - added new statuses disabledAlert and disabledWarning

Compare with previous version

requested review from @domonkosgulyas, @imretoth, @maxfrederiksen, and @anderslindh1

marked this merge request as ready

changed the description

added 1 commit

• fa0ef035 - added new statuses disabledAlert and disabledWarning

Compare with previous version

changed the description

Just had a look at test, and it seems correct. Was surprised by the number of disabled IOCs (50 rows per page, 1st page) and thought there might be a bug, but the ones I checked on actually all seem correct.

Some minor comments, not sure if worth doing anything about:

• "with alert" vs "with warning": warning is an alert, of warning severity, just as error is an alert with error severity
• popover says (for example) "disabled with alert(s)": this should maybe just have said "disabled", as the "with alert(s)" text makes it more difficult to quickly read the first word (e.g. disabled)