Skip to content
Snippets Groups Projects

CE-2971: Add git ref fallback for missing commit in git history

Merged CE-2971: Add git ref fallback for missing commit in git history
Merged Max Frederiksen requested to merge CE-2971 into develop

This simply adds a fallback in the JobGitRefLink component in the case of a missing commit in the git history.

We decided to remove the link and keep it as plain text in order to differentiate from normal commits that exist both in gitlab and git history.

Follow-up:

  • Create a Review task of the JobsGitRefLink component as a whole, it's implementation and usage. while working on this ticket I felt like we are potentially doing unnecessary requests for data that we already receive from the `job` prop. There will probably also be some refactoring that could improve the components flexibility. However I felt like that was way outside the scope of this ticket so will create a follow-up Review ticket for this.

How it looks now

Individual job page:

Screenshot 2024-08-15 at 16.03.49.png

Jobs page:

Screenshot 2024-08-15 at 16.04.07.png

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading