CE-3090: Structured heading levels

added 1 commit

34e1b12a - deleted typography

added 1 commit

1ec3edfc - replaced h3 with h2 where appropriate

requested review from @domonkosgulyas, @imretoth, @maxfrederiksen, and @skybrewer

What is the reason for keeping variant to h3, couldn't we get the same affect by simply setting component to h3 and removing variant?

No, then the html element would be a h3, component is the html tag, variant is the style in MUI theme.

This is a little bit related to what we talked about the other day. That maybe we should set our own styles based on font size, font weight and color so that we don't need to use variant... it is confusing and results in typography wild west

If this isn't super high prio, then maybe that is a better solution. That was a thought I had when I joined the team, but thought would be a big ticket.

Yeah, it probably will be a rather large ticket and I don't believe it is a good solution to replace bit by bit, then it will never be done properly.

I could write a separate ticket for that and then you and I and Max can discuss how we want to approach it?

Maybe I worded it wrong but I was curious as to why we need to use a h2 element instead of h3? In my head if we want the styling of an h3 why not simply use the h3 element tag

Because we want the heading hierarchy of an h2, since you shouldn't have an h3 element that does not have an h2 "parent", but we want the styling of an h3 (as it is declared in common)

This ticket is about getting h-level hierarchy correct for each page and that is done by replacing the h3 with h2 where appropriate. If this is still unclear, ping me and let's have a huddle.

approved this merge request

mentioned in commit f8a75ba5

merged

CE-3090: Structured heading levels

Merge request reports

Activity