CE-3202-batch-jobs-in-details-view
All threads resolved!
All threads resolved!
Note: No batch jobs from BE yet, validate changes by looking at job details story.
Edited by Johanna Szepanski
Merge request reports
Activity
assigned to @johannaszepanski
added 4 commits
Toggle commit listadded 14 commits
-
b73f5ecb...e9e1b8ee - 6 commits from branch
develop
- 594accfd - changed size of unknown icon
- 9fd93bea - Removed no longer used components
- 298850c0 - migrated JobIcons to typescript
- 00875eff - replace the JobBadge with just job icon and job type text
- b3606fc1 - removed host and revision from key value table and replaced it with a list table
- 3f011406 - removed job api call and instead using data from operations call
- 0b2fdd96 - fixed broken story and updated mock data
- 5ca59743 - Support for batch jobs in job details view
Toggle commit list-
b73f5ecb...e9e1b8ee - 6 commits from branch
added 7 commits
- c0ac218a - Removed no longer used components
- 6657dbe5 - migrated JobIcons to typescript
- d67346c0 - replace the JobBadge with just job icon and job type text
- 21b9e2ce - removed host and revision from key value table and replaced it with a list table
- e058c685 - removed job api call and instead using data from operations call
- ef0b416d - fixed broken story and updated mock data
- f0e1a6ca - Support for batch jobs in job details view
Toggle commit listrequested review from @maxfrederiksen and @skybrewer
- Resolved by Sky Brewer
- Resolved by Sky Brewer
- Resolved by Sky Brewer
Maybe we want a follow up for the JobDetailsView. I think it would be good to have some kind of title to the deployment. Maybe also having the times at the top above the ioc list might make sense.
- Resolved by Johanna Szepanski
Besides the comment I made above I think it looks really good, nice work
I saw a couple of files using the old useApiMethod but I assume you will take those in your upcoming "convert to TSX" ticket.
added 1 commit
- 2d7f06ab - added a job utils file to hold common functionality
mentioned in commit 5c08847a
Please register or sign in to reply