CE-3632: MR comments

src/components/common/EllipsisText/EllipsisText.tsx

@@ -4,42 +4,35 @@ import {
   TypographyProps,
   TooltipProps
 } from "@mui/material";
+import { EmptyValue } from "../EmptyValue";
 
 export interface EllipsisTextProps {
-  title?: string;
-  disableTooltip?: boolean;
   TypographyProps?: TypographyProps;
   TooltipProps?: TooltipProps;
-  children: string;
+  children?: string;
 }
 
 export const EllipsisText = ({
-  title,
-  disableTooltip = false,
   TypographyProps,
   TooltipProps,
   children
 }: EllipsisTextProps) => {
-  const renderedText = (
-    <Typography
-      noWrap
-      {...TypographyProps}
-    >
-      {children}
-    </Typography>
-  );
-
-  if (disableTooltip) {
-    return renderedText;
-  }
-
   return (
     <Tooltip
-      title={title ?? children}
+      title={children}
       arrow
       {...TooltipProps}
     >
-      {renderedText}
+      {children ? (
+        <Typography
+          noWrap
+          {...TypographyProps}
+        >
+          {children}
+        </Typography>
+      ) : (
+        <EmptyValue />
+      )}
     </Tooltip>
   );
 };

src/stories/common/EllipsisText/EllipsisText.stories.tsx

@@ -52,7 +52,6 @@ Default.args = {
   TypographyProps: {
     variant: "body2"
   },
-  disableTooltip: false,
   TooltipProps: {
     placement: "right-end"
   }
@@ -60,14 +59,16 @@ Default.args = {
 
 const ExternalLinkTemplate = ({ children, ...props }: EllipsisTextProps) => {
   return (
-    <Container>
-      <ExternalLink
-        to="https://europeanspallationsource.se/"
-        label={children}
-      >
-        <EllipsisText {...props}>{children}</EllipsisText>
-      </ExternalLink>
-    </Container>
+    <MemoryRouter>
+      <Container>
+        <ExternalLink
+          to="https://europeanspallationsource.se/"
+          label={children}
+        >
+          <EllipsisText {...props}>{children}</EllipsisText>
+        </ExternalLink>
+      </Container>
+    </MemoryRouter>
   );
 };
 

src/stories/fields/Autocomplete.stories.tsx

@@ -57,16 +57,6 @@ const Template = ({ loading, ...args }: AutocompleteProps) => {
   );
 };
 
-export const Default = (args: typeof Autocomplete) => (
-  <Template
-    loading={false}
-    {...args}
-  />
-);
+export const Default = () => <Template loading={false} />;
 
-export const Loading = (args: typeof Autocomplete) => (
-  <Template
-    loading
-    {...args}
-  />
-);
+export const Loading = () => <Template loading />;