Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C ce-ui-common
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ccce
  • dev
  • ce-ui-common
  • Merge requests
  • !22

ICSHWI-11854: width open closed warning

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Christina Jenks requested to merge ICSHWI-11854_width-open-closed-warning into main Feb 28, 2023
  • Overview 9
  • Commits 6
  • Pipelines 5
  • Changes 11

Addresses the warning about widthOpen and widthClosed being unrecognized DOM attributes:

Warning: React does not recognize the `widthOpen` prop on a DOM element.

This is due to the widthOpen and widthClosed props being used in the defaultStyle applied to the MenuDrawer, but missing from the props for that component.

I also found during investigation a similar warning for totalCount in the Table component. This was more tricky, as it was caused by destructuring the pagination prop. However, on investigation of the underlying DataTable api (https://primereact.org/datatable/#paginator) I found there was a similar prop totalRecords that it should have been mapping to but wasn't. The consequence of this would be setting totalCount but having the value not reflected in the pagination element (would always be the default of 1000 records). I included a fix for that as well here, being careful not to destructure totalRecords into totalRecords: undefined.

Edited Mar 01, 2023 by Simon Rose
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ICSHWI-11854_width-open-closed-warning