Skip to content
Snippets Groups Projects

CE-3638: Migrate iconbadge and iconmenubutton

Merged Johanna Szepanski requested to merge CE-3638-migrate-iconbadge-iconmenubutton into main

IconBadge:

  • Migrated to TS
  • Removed never used secondIcon from props
  • Cleaned up jsx and added gap prop (margins and stuff should be set in consuming applications)

IconMenuButton:

  • Migrated to TS
  • Removed a weird conditional sx props for the button, (should be set in consuming applications)
  • Added a follow-up to revisit this component. It tries to handle too much. Preferably separate it into two components. One IconButton and one IconMenuButton.

For testing in consuming applications there are draft MR:s:
D&M: ce-deploy-ui!631 (merged)
Naming: ce-naming-ui!58 (merged)
Template: ce-template!22 (merged)

Edited by Johanna Szepanski

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading