Skip to content

Decouple FEN regMap from topology

Marco Filhorequested to merge
fen-maps-cherry-pick into main

This is an initial attempt to make FENBase and RMMAPI a little more independent of one another: the addresses maps now belong to the FEN, meaning two advantages:

1 - Reduced code complexity: getInternalRegAddres only needs to access this->regMap instead of asking for the API with: const std::unordered_map<std::string, uint32_t>& regMap = rmmAPI->getTopology().getAddrMap(this->ring, this->node);

2 - It's should now be possible to use userRegRead in the FEN constructor, because it no more depends on the topology object being populated with it. It also lets topology only worry about the physical topology, instead of having to store the regMaps from the FENs, which are now stored in the actual FENs.

This is based simply on a personal opinion about the code design, and not in any particular need. So it's not important for anyone but it makes the grumpy gnome that lives in my head less grumpy.

Merge request reports