E3-961: More rules implementations (!2) · Merge requests · ESS EPICS Environment / dbformat · GitLab

Snippets Groups Projects

Merged Lucas Magalhães requested to merge more-rules-implementation into main 2 years ago

There is a known issue in this patchset. If there is comment just before the first info tag. This will mess up the DB008 regex match and if this is done after DB010 it will remove the extra line needed between last field and first info.

Activity

Lucas Magalhães requested review from @anderslindh1, @douglasaraujo, and @simonrose 2 years ago

requested review from @anderslindh1, @douglasaraujo, and @simonrose
Anders Lindh Olsson @anderslindh1 · 2 years ago

Owner

Resolved 2 years ago by Anders Lindh Olsson

Mostly LGTM. Some concerns about the issue with DB008 and DB010, but not sure how we best handle this.

You have a typo in the message for commit 7558c862.

Last reply by Lucas Magalhães 2 years ago
Lucas Magalhães added 2 commits 2 years ago
added 2 commits

20656f84 - Add DB013 pattern and test

871020fb - Add DB014 pattern and test

Compare with previous version
Simon Rose @simonrose started a thread on an old version of the diff 2 years ago

Resolved 2 years ago by Lucas Magalhães
Last reply by Simon Rose 2 years ago

Simon Rose @simonrose started a thread on an old version of the diff 2 years ago

Resolved 2 years ago by Lucas Magalhães

Lucas Magalhães added 4 commits 2 years ago

added 4 commits

c59bb884 - Add DB008 pattern and test
48201772 - Fix DB007 description
ac6b317d - Add DB013 pattern and test
dc0c27eb - Add DB014 pattern and test

Compare with previous version

Toggle commit list

Lucas Magalhães added 2 commits 2 years ago

added 2 commits

6a523249 - Fix DB009 should not account for \n
ef7dc5f3 - Add DB010 pattern and test

Compare with previous version

Lucas Magalhães added 1 commit 2 years ago

added 1 commit

8de599d3 - Fix DB008 accounts for comment...

Compare with previous version

Anders Lindh Olsson resolved all threads 2 years ago

resolved all threads

Anders Lindh Olsson @anderslindh1 started a thread on an outdated change in commit 163deb9e 2 years ago

Resolved 2 years ago by Lucas Magalhães

Anders Lindh Olsson @anderslindh1 started a thread on an outdated change in commit dc0c27eb 2 years ago

Resolved 2 years ago by Lucas Magalhães

Anders Lindh Olsson @anderslindh1 started a thread on an outdated change in commit 8de599d3 2 years ago

Resolved 2 years ago by Lucas Magalhães

Simon Rose @simonrose started a thread on an old version of the diff 2 years ago

Resolved 2 years ago by Lucas Magalhães

Lucas Magalhães added 2 commits 2 years ago

added 2 commits

42dc7a0a - Fix DB008 accounts for comment line between last field and first info
ee0bbab5 - Add DB010 pattern and tests

Compare with previous version

Lucas Magalhães added 4 commits 2 years ago

added 4 commits

9de9e4a3 - Add DB014 pattern and test
be75dfbc - Fix DB009 should not account for \n
a66d469e - Fix DB008 accounts for comment line between last field and first info
03353c05 - Add DB010 pattern and tests

Compare with previous version

Toggle commit list

Lucas Magalhães @lucasmagalhaes · 2 years ago

Author Owner

I decided to add DB010 after all. It's complex but works fine.

Lucas Magalhães added 2 commits 2 years ago

added 2 commits

3093fac5 - Fix DB008 accounts for comment line between last field and first info
fc506300 - Add DB010 pattern and tests

Compare with previous version

Lucas Magalhães added 6 commits 2 years ago

added 6 commits

0233a5dc - Add pattern and tests for DB009
392e25f5 - Add DB008 pattern and test
7ba6ae62 - Fix DB007 description
118be42f - Add DB013 pattern and test
60c60b62 - Add DB014 pattern and test
8653c2af - Add DB010 pattern and tests

Compare with previous version

Toggle commit list

Lucas Magalhães resolved all threads 2 years ago

resolved all threads

Anders Lindh Olsson approved this merge request 2 years ago

approved this merge request

Please register or sign in to reply