Skip to content
Snippets Groups Projects
Commit c2ec5f9a authored by Simon Rose's avatar Simon Rose
Browse files

Minor cleanup

parent 3d10ff93
No related branches found
No related tags found
1 merge request!132E3-1066: Refactor require.c
...@@ -1079,12 +1079,12 @@ static int require_priv(const char *module, const char *version) { ...@@ -1079,12 +1079,12 @@ static int require_priv(const char *module, const char *version) {
"%n%s.dep", "%n%s.dep",
founddir, &releasediroffs, targetArch, &libdiroffs, module)) { founddir, &releasediroffs, targetArch, &libdiroffs, module)) {
/* filename = /* filename =
"<dirname>/[dirlen]<module>/<version>/R<epicsRelease>/[releasediroffs]/lib/<targetArch>/[libdiroffs]/module.dep" "<dirname>/[dirlen]<module>/<version>/[releasediroffs]/lib/<targetArch>/[libdiroffs]/module.dep"
*/ */
fprintf(stderr, "Dependency file %s not found\n", filename); fprintf(stderr, "Dependency file %s not found\n", filename);
} else { } else {
/* filename = /* filename =
* "<dirname>/[dirlen]<module>/<version>/R<epicsRelease>/[releasediroffs]/lib/<targetArch>/[libdiroffs]/module.dep" * "<dirname>/[dirlen]<module>/<version>/[releasediroffs]/lib/<targetArch>/[libdiroffs]/module.dep"
*/ */
if (handleDependencies(module, filename) == -1) return -1; if (handleDependencies(module, filename) == -1) return -1;
} }
...@@ -1093,12 +1093,12 @@ static int require_priv(const char *module, const char *version) { ...@@ -1093,12 +1093,12 @@ static int require_priv(const char *module, const char *version) {
if (!(TRY_FILE(libdiroffs, PREFIX "%s" INFIX "%n" EXT, module, &extoffs))) { if (!(TRY_FILE(libdiroffs, PREFIX "%s" INFIX "%n" EXT, module, &extoffs))) {
/* filename = /* filename =
"<dirname>/[dirlen]<module>/<version>/R<epicsRelease>/[releasediroffs]/lib/<targetArch>/[libdiroffs]/PREFIX<module>INFIX[extoffs](EXT)?" "<dirname>/[dirlen]<module>/<version>/[releasediroffs]/lib/<targetArch>/[libdiroffs]/PREFIX<module>INFIX[extoffs](EXT)?"
*/ */
printf("Module %s has no library\n", module); printf("Module %s has no library\n", module);
} else { } else {
/* filename = /* filename =
* "<dirname>/[dirlen]<module>/<version>/R<epicsRelease>/[releasediroffs]/lib/<targetArch>/[libdiroffs]/PREFIX<module>INFIX[extoffs]EXT" * "<dirname>/[dirlen]<module>/<version>/[releasediroffs]/lib/<targetArch>/[libdiroffs]/PREFIX<module>INFIX[extoffs]EXT"
*/ */
printf("Loading library %s\n", filename); printf("Loading library %s\n", filename);
if ((libhandle = loadlib(filename)) == NULL) return -1; if ((libhandle = loadlib(filename)) == NULL) return -1;
...@@ -1161,14 +1161,11 @@ static int require_priv(const char *module, const char *version) { ...@@ -1161,14 +1161,11 @@ static int require_priv(const char *module, const char *version) {
registerModule(module, found, filename); registerModule(module, found, filename);
} }
status = 0;
if (requireDebug) printf("require: looking for template directory\n"); if (requireDebug) printf("require: looking for template directory\n");
/* filename = /* filename =
* "<dirname>/[dirlen]<module>/<version>/R<epicsRelease>/[releasediroffs]..." * "<dirname>/[dirlen]<module>/<version>/[releasediroffs]..."
*/ */
if (!((TRY_FILE(releasediroffs, TEMPLATEDIR) || if (!(TRY_FILE(releasediroffs, TEMPLATEDIR) &&
TRY_FILE(releasediroffs, ".." OSI_PATH_SEPARATOR TEMPLATEDIR)) &&
setupDbPath(module, filename) == 0)) { setupDbPath(module, filename) == 0)) {
/* if no template directory found, restore TEMPLATES to initial value */ /* if no template directory found, restore TEMPLATES to initial value */
char *t; char *t;
...@@ -1177,15 +1174,6 @@ static int require_priv(const char *module, const char *version) { ...@@ -1177,15 +1174,6 @@ static int require_priv(const char *module, const char *version) {
putenvprintf("TEMPLATES=%s", globalTemplates); putenvprintf("TEMPLATES=%s", globalTemplates);
} }
if (founddir) free(founddir);
/* no need to execute startup script twice if not with new arguments */
if (loaded) {
return 0;
}
return status;
require_priv_error: require_priv_error:
if (founddir) free(founddir); if (founddir) free(founddir);
return returnvalue; return returnvalue;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment