Skip to content
Snippets Groups Projects
  1. Oct 14, 2022
  2. Oct 13, 2022
  3. Oct 12, 2022
  4. Sep 28, 2022
  5. Sep 27, 2022
  6. Sep 20, 2022
  7. Sep 15, 2022
  8. Sep 14, 2022
    • Simon Rose's avatar
      Merge branch 'e3_944_warn_if_building_from_install_path' into 'master' · 9de76918
      Simon Rose authored
      E3-944: Warn if building from install path
      
      See merge request e3/e3-require!99
      9de76918
    • Simon Rose's avatar
      E3-944: Warn if building from install path · df112375
      Simon Rose authored
      If a user runs the build from the E3_SITEMODS_PATH, then it can happen that
      false dependencies get registered due to how the generated .d files are
      parsed to determine module dependencies. Specifically, if you have header
      file being used that is located at
      
      ${E3_SITEMODS_PATH}/e3-module/module/src/header.h
      
      and it is _not_ being installed, then the dependency parsing script will
      see a dependency as an absolute path, and so register that your module
      depends on the module `e3-module` version `module`, which is obviously
      not what was intended.
      
      While we don't want to stricly _prevent_ a user from building there, it
      seems wise to _warn_ a user that there may be unintended consequences.
      df112375
  9. Sep 09, 2022
  10. Sep 07, 2022
  11. Sep 02, 2022
  12. Aug 22, 2022
  13. Aug 19, 2022
    • Simon Rose's avatar
    • Simon Rose's avatar
      E3-921: Add test to ensure that failed architectures cause build to fail · 818eafee
      Simon Rose authored
      This adds a test that checks that if a single architecture fails, then the build
      fails as a whole.
      
      There are some slight complications in terms of writing good tests, since we do not
      want to use real architectures. Since the source files are converted from
      `SOURCES -> SRCS -> LIBOBJS` and we finally have the dependency
      ```make
      ${DEPFILE}: ${LIBOBJS}
      ```
      we need to ensure that `LIBOBJS` is properly populated before we get to this point.
      The challenge, however, is that `LIBOBJS` is defined (in terms of `SRCS` as
      ```make
      LIBOBJS += $(addsuffix $(OBJ),$(notdir $(basename $(filter-out %.$(OBJ) %$(LIB_SUFFIX),$(sort ${SRCS})))))
      ```
      and `LIB_SUFFIX` is set in `${CONFIG}/os/CONFIG.Common.${T_A}`. This is why
      we need to do the workaround of hand-defining it at the beginning.
      818eafee
    • Lucas Magalhães's avatar
      Merge branch 'E3-920' into 'master' · 65814b54
      Lucas Magalhães authored
      E3-920: Set custom E3_MODULES_PATH for test target
      
      See merge request e3/e3-require!93
      65814b54
  14. Aug 18, 2022
    • Lucas Magalhães's avatar
      Set custom E3_MODULES_PATH for test target · 88154b18
      Lucas Magalhães authored
      The test rule for e3 modules actually does a cellinstall and run the
      tests inside this temporary installation. The cellinstall needs to
      overwrite some path variables to work this variables were not accessible
      through the test rule as they are just changed if cell is on
      MAKECMDGOALS. This made impossible to use the standard path variables
      inside module's custom test rules.
      
      To fix it the same mechanism used in cellinstall is implemented for test
      and the variables paths are now overwritten. This makes possible ie. to
      use E3_MODULES_INSTALL_LOCATION_BIN inside custom test rules.
      
      This commit also introduces an unwanted behavior. As the test rule is
      now overwriting the standard path variables it cannot longer be along
      with the install rule. For example, running `make test install` will
      install the module inside the test dir. This is a known issue for
      cellinstall as well and a restructure of the Makefile code should be
      made to isolate the rules.
      88154b18
  15. Aug 17, 2022
  16. Aug 10, 2022
  17. Aug 09, 2022
Loading