Skip to content

E3-1112: Move module_VERSION definitions to first make call

Lucas Magalhães requested to merge fix_dbexpansion into master 
From e3-require 4.0.0 to 5.0.0 we changed FETCH_BUILD_NUMBER to
FETCH_REVISION_NUMBER. But the following error happens if you try to
build e3-adandor, for example:

2023-01-19 13:41:49,129 [  DEBUG  ] e3.utils: stderr: HEAD is now at 6f3a1f4... Merge pull request #44 from sudilav/master
msi: Can't open file 'ADBase.template'
input: 'include "ADBase.template"
' at line 5 of  file andorApp/Db/andorCCD.template

The root cause is a mixture of two things, a change we made for 5.0.0
and an old behavior:
1. We changed when the db expansions happen in
b226a847c403eba79bc91efee18d225ed2753c7
2. The variables holding the dependency versions are defined on the
second make call after defining T_A.

This commit fixes the issue by moving the module_VERISON definitions
to the first make call. Whit this we restrict the usage of
FETCH_REVISION_NUMBER to the modules defined as a dependency in
configure/CONFIG_MODULE.

Merge request reports