Cppcheck fixes (!187) · Merge requests · ecdc / ess-dmsc / event-formation-unit-old · GitLab

This is an archived project. Repository and other project resources are read-only.

Jekabs Karklins requested to merge cppcheck_fixes into master Jan 07, 2019

Created by: SkyToGround

Issue reference / description

What I have done:

Updated the Debian build image version so that the latest version (1.86) of cppcheck is used.
Fixed many of the issues found by cppcheck.
Removed a some dead code indicated as such by cppcheck.
General minor improvements and fixes as I came across them.

What I have not done:

Implement cppcheck suggestions to use the stl algorithms instead of raw (for) loops.

Checklist for submitter

Make sure that the code looks sensible and that there is no change in functionality.

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

Recommend for group code review

Also, nominate it on the code_review Slack channel.