Skip to content

Issue 215

Jekabs Karklins requested to merge issue_215 into master

Created by: martukas

Issue reference / description

We need these changes and we need them pretty much immediately to ensure that the flatbuffer schema contract between the EFU and daquiri is not broken. Apparently, we have been using the schema wrong in a few pipelines. This fix concerns two problems:

  • Some of the fb schema (mo01 in particular) did not have full headers with flatbuffer schema id attached. This made it impossible to discriminate different types of messages on multiplexed topics. To achieve this, you have to close the builder with the schema-generated function, and not the generic builder one.
  • Apparently there is an assumption that a "source_name" field must be included in all buffers for more granular filtering of messages -- again, further multiplexing.
  • Tests have been improved to check for conformance with these assumptions.

The second of these expectations has come to me as a bit of a surprise, because while that may have been a working assumption for the file writer, this requirement was never explicitly conveyed to us. In any case, these changes ensure that we conform to these assumptions. The code is not perfect. The classes in question are scheduled to be rewritten anyways. We need these changed merged now to ensure compatibility with daquiri, as changes therein are required by Jonas at V20 to monitor multiplexed streams.

The branch you merge from should already reference an event-formation-unit github ticket number. You can add a descriptive title, but if an issue is referenced, you don't have to.

Checklist for submitter

  • Check for conflict with integration test
  • Unit tests pass

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel.

Merge request reports