Skip to content

Issue 335 loki instrument

Jekabs Karklins requested to merge issue_335_loki_instrument into master

Created by: mortenjc

Issue reference / description

  • Refactored stuff away from LokiBase.cpp as it is not so easy to unit test.
  • Implemented a ew LoKI calibration file format
  • Added a few unit tests in various other places as I got inspired to do som testing. Removed some dead code but no substantial code changes.

The branch you merge from should already reference an event-formation-unit github ticket number. You can add a descriptive title, but if an issue is referenced, you don't have to.

Checklist for submitter

  • Check for conflict with integration test
  • Unit tests pass

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel.

Merge request reports