Skip to content

Issue 112 cmd server crash

Jekabs Karklins requested to merge issue_112_cmd_server_crash into master

Created by: mortenjc

Issue reference / description

Basically improve the server code which was some copy-paste stuff that I didn't spend much time on eons ago when it was added. Fixed a few bugs which should make it more robust.

I have done aggressive tests with multiple simultaneous command requests and high data rates without being able to trigger the crash that was previously easy to trigger. It's certainly not worse than before.

As a side benefit, I added the support for trace/log groups for the LOG() macro. This actually accounts for the large number of files changes where LOG(...) was changed to LOG(GROUP, ...)

The most important change for the crash is in Server.cpp/h

Checklist for submitter

  • Check for conflict with integration test
  • Unit tests pass - there are no unit tests for this (low level socket programming)

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel.

Merge request reports