Skip to content

Issue 148

Jekabs Karklins requested to merge issue_148 into master

Created by: martukas

This is a generalization of the clustering code. It is well documented and tested, in particular, as compared to where it comes from.

There are abstract interfaces for clustering and cluster matching strategies. Additional implementations will be created based on the specific needs of pipelines. It is also possible that in the future, I will make some of these classes templates, allowing for customizing of the Cluster and Event classes in other ways (i.e. for gdgem), but for now, this is a good starting point.

I propose we merge this now, before I add too much pipeline-specific code. This way we again avoid having huge PRs.

Checklist for submitter

  • Check for conflict with integration test
  • Unit tests pass

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel.

Merge request reports