Skip to content

Add docker-based system tests

Jekabs Karklins requested to merge add_dockerfile into master

Created by: matthew-d-jones

#190 (closed) / Add docker-based system tests

Closes #190 (closed)

Instructions for running the tests are included in a markdown file in the system-tests directory, which is linked to in the main README.md.

Currently there is only one test, here, which simply checks that EFU receives the expected number of packets over UDP.

There are some changes to the python scripts in utils/. I refactored verifymetrics.py so that I could import and use it in the system test. i also made some changes so that the scripts work in Python 3. NB This means we would need to make a small change to the integration test ansible script before merging this PR. If lack of Python 2 support causes you any other problem then I should be able to make the changes work in both versions, but I didn't want to put the effort into that before being sure it is required.

Whilst the system-tests are running, the Kafka broker is exposed on port 9094 of the host machine. It is therefore possible to set a breakpoint in the system test and have a look at what messages have been published by the EFU. For example using kafkacow:

kafkacow -C -b localhost:9094 -t FREIA_detector -p 0

Checklist for submitter

  • Check for conflict with integration test
  • Unit tests pass

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel.

Merge request reports