Skip to content

Issue 332 restructure src

Jekabs Karklins requested to merge issue_332_restructure_src into master

Created by: mortenjc

Issue reference / description

Basically I have moved detector modules into a modules folder and made the corresponding cmake changes. No new functionality has been added. I have removed a udpgen_jalousie2 which was nearly identical with udpgen_jalousie. I have aligned cmake files for the modules to look more similar and I have moved TestUDPServer to test/ because it was located in adc_readout but used by other modules too.

The project builds, the tests builds both on my laptop and on Jenkins. There might be, but I can't know in advance, problems with the integration test. At least I am not aware of any.

I would probably not look theough this in github but rather check out the branch and see if the new structure seems resonable.

Checklist for submitter

  • Check for conflict with integration test
  • Unit tests pass

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel.

Merge request reports