Skip to content

Issue 345 loki data

Jekabs Karklins requested to merge issue_345_loki_data into master

Created by: mortenjc

I kept the old branch (which I probably shouldn't have) so there are new and old (already reviwed) changes here. do a

git diff 959e8619
To see the new changes which are:

  • added a udp generator for raw loki detector data files (provided by Davide/STFC)
  • applied the new calibration based straw position corrections
  • added/changed the calibration json file to a simpler format

Issue reference / description

The branch you merge from should already reference an event-formation-unit github ticket number. You can add a descriptive title, but if an issue is referenced, you don't have to.

Checklist for submitter

  • Check for conflict with integration test
  • Unit tests pass

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel.

Merge request reports