Skip to content

Fixed undefined behaviour and removed dead code

Afonso Mukai requested to merge issue_156 into master

Created by: SkyToGround

Fixes #156 (closed)

Things changed in this pull request:

  1. Removed the use of malloc/delete (undefined behaviour).
  2. Removed dead code caused by switching out Alloc.h/AllocStd.h for new.
  3. Minor CMake fix and fixes required by the above mentioned changes.

Not having been involved in the design of FileWriter::Msg, this class seems fragile and overly complicated to me. There might be a good reason for this but I want to point out that my gut reaction is that this class really could do with some unit tests and the use of unique_ptr.

Merge request reports