Skip to content

Fix missing topic issue

Afonso Mukai requested to merge topic_partition_failure into master

Created by: michele-brambilla

Description of work

This PR fixes an issue which shows when a topic is not present in the broker. In this case the filewriter throws an error and removes the stream associated with the topic.

Issue

Closes #183 (closed)

Other

It is questionable if the filewriter should remove the stream or keep trying connecting. Here we assume that all the topics have to be created in the broker during some configuration stage (whatever configuration stage could mean) before the write command is issued.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports