Skip to content

React only on commands addressed to service

Afonso Mukai requested to merge react_only_on_commands_addressed_to_service_id into master

Created by: dominikwerder

Description of work

  • On incoming filewriter command, check if it contains a service_id.
  • If not, we currently accept the command for compatibility. Behavior can be changed in the future in one line.
  • If yes, we check if it matches the service_id of the running instance before we accept the command.
  • The service_id can be given to the filewriter via CLI option or configuration file.

Issue

Closes https://jira.esss.lu.se/browse/DM-726

Acceptance Criteria

Filewriter should accept command only if service_id matches, or not given in command. Should get an integration test.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports