Skip to content

Restore streamer.cpp in tests

Afonso Mukai requested to merge restore-streamer-tests into master

Created by: michele-brambilla

Description of work

Restore the tests for the Streamer class. See README->Running tests.

Issue

Not an issue, ticket DM-399

Unit Tests

Tests handling of the following failures (and successes):

  • missing constructor arguments
  • configuration creation
  • missing topic
  • connection to the broker
  • consumer timeouts

Other

Here we want to test the Streamer response to network calls. In order to do that we need to fake the rdkafka library: such an implementation can be found in ess-dmsc/librdkafka-fake. Of course I'm open to alternatives.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports