Skip to content

Warnings as errors

Afonso Mukai requested to merge 199_warnings_as_errors into master

Created by: matthew-d-jones

Description of work

Adds -Wall and -Werror compiler flags to treat warnings as errors, this will stop us from reintroducing warnings. A single warning was being thrown by clang on OS X, so I also fixed that.

Issue

Closes #199 (closed)

Acceptance Criteria

Passing on Jenkins. If there are warnings Jenkins will now report failure.

Unit Tests

N/A

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports