Skip to content

Jira dm 935 incorporate essiip deployment

Afonso Mukai requested to merge JIRA_DM-935_incorporate_essiip_deployment into master

Created by: amues

Description of work

Add release build to Jenkins and archive artefacts. The main CMakeLists.txt file was modified to create binaries inside bin folder in release mode. An additional include was required because of a linking error that only occurred in the release build. These changes allow the file writer to be deployed to the integration test directly from master.

Issue

Closes JIRA DM-935.

Acceptance Criteria

Release build is created, tests pass and artefact is generated for deployment.

Unit Tests

The only change made to tests was the addition of an include to src/tests/NeXusDatasets.cpp.

Other

None.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports