Skip to content

Issue 203

Afonso Mukai requested to merge issue_203 into master

Created by: SkyToGround

Description of work

This PR was created in order to encourage the implementation of missing functionality into the file writer. Thus the changes are mostly the addition of failing unit tests.

Issue

See Ref #203 (closed)

Acceptance Criteria

Make sure that the code makes sense. The unit tests are currently meant to fail as the functionality for which they should test does not yet exist.

Unit Tests

7 unit tests have so far been added in src/tests/CommandHandlerTest.cpp under the category CommandHandlerTest.

Other

Made minor modifications to the main application code in order to simplify unit testing.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports