Skip to content

Remove MainOpt constructor and add init

Afonso Mukai requested to merge JIRA_DM-927_integration-test-issue into master

Created by: amues

The presence of the constructor causes the file writer not to write data to file in the integration test (the command is received, as the NeXus file is created with the correct structure). Just commenting out the contents of the constructor makes no difference. As a temporary solution, an init function was added to initialise the variable that was being initialised in the constructor. If the cause of the problem is discovered and fixed, the constructor can be reintroduced.

Description of work

See commit text above.

Issue

Closes JIRA DM-927

Acceptance Criteria

The build succeeds, unit tests pass and the integration test passes.

Unit Tests

src/tests/HDFFile.cpp and src/tests/MainOptTest.cpp have been modified to call the new init function after the MainOpt struct is created.

Other

For the sake of elegance and resource management, the new init should be replaced by the constructor after the problem is understood and fixed.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports