Skip to content

Fix writing event_time_offset dataset in ev42 writer module

Afonso Mukai requested to merge 229_Fix_bug_in_writing_event_time_offset_dataset_in_ev42 into master

Created by: matthew-d-jones

Description of work

There was some temporary development/debugging code left active, which meant that every value in the dataset was set to the process id. I've removed the offending code. This writer module really needs unit tests, I've created ticket #230 (closed) for this.

Issue

Closes #229 (closed)

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports