Skip to content

Fix start time

Afonso Mukai requested to merge fix-start-time into master

Created by: michele-brambilla

Description of work

With KafkaW used as librdkafka wrapper in the Streamer the start_time functionality was broken. This PR fixes the issue. If a start_time is provided rd_kafka_offsets_for_times is called on all the partitions to retrieve the first message not older than start_time.

Issue

Closes #233 (closed)

Acceptance Criteria

The following function have been added/modified

  • Consumer::queryNumberOfPartitions
  • Consumer::addTopic

Other

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports