Skip to content

Changed to dealing with fmt as a library and fixed bugs.

Afonso Mukai requested to merge issue_157 into master

Created by: SkyToGround

Description of work

As the title says. I had to make some minor changes to the cmake-code and I found two build issues. The bonus is that we are now using a newer version of the fmt library.

Issue

Closes #157 (closed)

Acceptance Criteria

Review the changes to see if they look reasonable.

Unit Tests

N/A

Other

We are now using the bincrafters conan package instead as it has the latest version of fmt and it provides its own FindFmt.cmake-file.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports