Skip to content

Commit offsets before subscribing to fix start time functionality

Afonso Mukai requested to merge 239_start_time_fix into master

Created by: matthew-d-jones

Description of work

Start time functionality is broken by an immediate partition rebalance after subscribe is called, which resets the offsets. The fix is to commit the offsets before calling subscribe.

Issue

Closes #239 (closed)

Acceptance Criteria

Test using data from NeXus-Streamer.

Unit Tests

N/A, change is in Kafka interface.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports