Skip to content

221 reject write message if job id in use

Afonso Mukai requested to merge 221_reject-write-message-if-job_id-in-use into master

Created by: michele-brambilla

Description of work

Each writing task must be tagged with a unique ID. So far a bug allowed two different task to have the same ID, causing different misbehaviours. In this PR we introduce a fix that reject the "write new" command if the jobID is already in use.

Issue

Closes #221 (closed)

Acceptance Criteria

  • the file writer should accept "write new" commands with different jobID
  • if a "write new" command is received but the jobID is already in use should drop the command

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports