Skip to content

Improved CMake code (JIRA issue DM-1019)

Afonso Mukai requested to merge JIRA_issue_DM-1019 into master

Created by: SkyToGround

Description of work

Minor changes to the CMake-code in order to modularise it and make future file-writing-module development slightly easier. Also had to make minor changes to the unit testing in order for code coverage to be properly calculated.

Issue

See JIRA issue DM-1019. This pull request does not close the JIRA issue but it does update it.

Acceptance Criteria

Review the CMake code in order to determine if the changes are useful/reasonable.

Unit Tests

N/A

Other

N/A


Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports