Skip to content

Fix of issue #265

Afonso Mukai requested to merge issue_265 into master

Created by: SkyToGround

Description of work

The issue was that C++ does not guarantee that static variables are instantiated unless they are used in a function and because the registrars were not used in any functions, they were not instantiated. This is a fix that appears to work though the fix is not guaranteed by the C++ standard. This was also true for the original design.

Now that I have figured out why we had the code coverage issues in #262, I have been able to remove the hack that I implemented for that PR.

Issue

Closes #265 (closed).

Acceptance Criteria

This should be tested in an integration test but I am confident that it will work.

Unit Tests

N/A

Other

N/A

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports