Skip to content

Fix of issue 266 (stop time)

Afonso Mukai requested to merge issue_266 into master

Created by: SkyToGround

Description of work

Turns out that I actually had not implemented unit tests for the changes to the stop time algorithm that I did. Thus this pull request reverts the code to the old algorithm and implements unit tests for it.

I also moved some of the set-up code for the unit tests into the test fixture.

Issue

Closes #266 (closed)

Acceptance Criteria

Reverted to old algorithm for stopping consumption of flatbuffer messages.

Unit Tests

Added the unit tests EmptyMessageAfterStop, EmptyMessageBeforeStop and EmptyMessageSlightlyAfterStop. Also created a new test fixture (and thus renamed) for the message timing tests.

Other

We probably want to get this merged as soon as possible.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports