Skip to content

Adding CLI11 ini configuration file support

Afonso Mukai requested to merge 275_ini_files into master

Created by: rerpha

Description of work

(Breaking change to anything that uses configuration files currently) This replaces the configuration JSON and adds anything that wasn't in the command line functionality to the command line options (besides librdkafka options for now)

Test coverage will decrease slightly as the json parsing stuff has been removed. There is no easy way to test CLI11s functionality nor should we as it's an external library but unfortunately this means that some lines of code have been added and can't be covered.

Issue

Closes #275 (closed)

Acceptance Criteria

Test that the filewriter still outputs files properly with manual tests/system tests if they are merged

Unit Tests

Deleted any unit tests that test the functionality of checking for options in the previous json configuration files as CLI11 now handles this.

Other

Updated README.md to show new .ini file usage.

Code Review (To be filled in by the reviewer only)

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?

Nominate for Group Code Review (Anyone can nominate it)

Indicate if you think the code should be reviewed in a Thursday code review session.

  • Recommend for group code review

Also, nominate it on the code_review Slack channel (does someone want to automate this?).

Merge request reports